Add the ability to share downloaded attachments. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor sharing into AttachmentFileShareController. Minor fixups.
|
@Dima-Android could you please have a look at this when you get the time? Shouldn't be too much of a major change, small QoL improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at:
This PR adds the ability to share downloaded attachment files (and technically text URLs, though this is unused) with other apps. Currently, one must long press the attachment in the Item Details view, or one can share all downloaded attachments for a library item by long pressing the item. More "findable" options can be implemented as desired.
This PR also rewords the AllItems "Remove Download" option to be more clear.
Screenshots:
