Added phys.org translator #3238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJellinek
requested changes
Feb 8, 2024
|
Thanks @AbeJellinek for helping to fix up all the mistakes I made! I think i've fixed all the issues you raised (except for one i've asked for your advice on). I'd also however be gratefully if you could take a look at the async code i've added. It was created mainly through cannibalising other translators because i've never used async in javascript before, so its very possible some errors have crept in. |
|
Strip the tags, but otherwise, looks good! |
|
Done. Thanks @AbeJellinek! |
AbeJellinek
requested changes
Apr 4, 2024
| "translatorID": "e835ac2f-181b-41fe-a509-4f9d20797515", | ||
| "label": "Phys.org", | ||
| "creator": "Laurence Stevens", | ||
| "target": "https?://(www\\.)?phys\\.org/news", |
There was a problem hiding this comment.
Wait, the target matches /news...
| if (url.includes('/news')) { | ||
| return 'blogPost'; | ||
| } | ||
| else if (url.includes('/search') && getSearchResults(doc, true)) { |
There was a problem hiding this comment.
So won't this else if never happen? The URL will always include /news.
| }); | ||
|
|
||
| let em = await translator.getTranslatorObject(); | ||
| em.itemType = type || "webpage"; |
There was a problem hiding this comment.
We can just do
Suggested change
| em.itemType = type || "webpage"; | |
| em.itemType = "blogPost"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a translator for the site phys.org, for which we previously weren't getting all metadata from. Also added support for the sites search feature. This should fix issue #2897.
This is my first time working with this codebase so i'd be grateful if whoever approves this could take a look over my code to make sure I haven't done something stupid through inexperience!