OFS/dtml/cacheable: Remove "New" from label #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, test is failing on OSX because of a problem installing packages, it does not look related. |
dataflake
approved these changes
Oct 29, 2024
drfho
approved these changes
Oct 29, 2024
|
Thank you for review, I submitted a fix for tests in #1234 I'll rebase this and merge once the tests are fixed (I can not merge now because of required status) |
In 6ac52aa#diff-1cd7357f6a0c6126e3279998f27d3c17f5d48e4940356bbe6f0266101828fb02R9 the label was changed from `Cache this object using` to `New Cache this object using`, this looks like left-overs from debugging.
perrinjerome
force-pushed
the
perrinjerome/new-cache
branch
from
402d59c
to
23c7f84
Compare
|
I merged this manually because the GHA Ubuntu runners are completely broken right now. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6ac52aa#diff-1cd7357f6a0c6126e3279998f27d3c17f5d48e4940356bbe6f0266101828fb02R9 the label was changed from
Cache this object usingtoNew Cache this object using, this looks like left-overs from debugging.