Run isort, autopep8 and flake8 in pre-commit. #1224
Conversation
There was a problem hiding this comment.
This is a readable PR, thanks.
By the way, this PR caught some files that are not included in the current tox configuration, like utils.py in the project root. So there's a discrepancy between a local tox run and what this PR has done that should be fixed at the same time.
|
I am going to remove these checks from tox, as running them once should be enough and we do not have the burden to maintain it in two places. |
|
There will be something left, either in tox or with instructions how to do it, to execute these checks before a push, right? |
|
I usually run pre-commit via tox, so there can't be a discrepancy between the local checks and those in CI, and then you even do not need to install pre-commit locally, but you certainly can. Something like this |
|
Right, I'd be interested in some invocation - preferably out of tox since that is the de-facto standard we use - to run the same steps locally that the GitHub action does. |
Removed things from .meta.toml still need to be added to meta/config.
This was the last missing piece I just added to zopefoundation/meta#265. |
|
Thank you for reviewing this PR. 😃 |
I excluded pre-commit from running locally, so the changes it made show up as a commit here in the PR. (I had to make some little changes which cannot be done automatically (too long line, indentation problems)
Open tasks:
Change logthis is just an interal change, no need to tell the world.isort,autopep8,flake8fromtox.ini(they need to run only once.)pre-commitjob in GHA to succeed (via meta/config)