Do not fail when request has no ensure_publishable method. #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may happen in tests.
In a Plone core development buildout with Zope master there are failures in `plone.dexterity`:
```
$ bin/test -s plone.dexterity -u
...
Error in test test_acquire_without_dav (plone.dexterity.tests.test_webdav.TestDAVTraversal.test_acquire_without_dav)
Traceback (most recent call last):
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
yield
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 623, in run
self._callTestMethod(testMethod)
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
if method() is not None:
File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/tests/test_webdav.py", line 1174, in test_acquire_without_dav
r = traversal.publishTraverse(request, "item")
File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/browser/traversal.py", line 40, in publishTraverse
defaultTraversal = super().publishTraverse(request, name)
File "/Users/maurits/community/plone-coredev/6.0/src/Zope/src/ZPublisher/BaseRequest.py", line 142, in publishTraverse
self.request.ensure_publishable(subobject)
AttributeError: 'DAVTestRequest' object has no attribute 'ensure_publishable'
...
Error in test test_get_acquired (plone.dexterity.tests.test_webdav.TestDexterityPublishTraverse.test_get_acquired)
Traceback (most recent call last):
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
yield
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 623, in run
self._callTestMethod(testMethod)
File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
if method() is not None:
File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/tests/test_webdav.py", line 1309, in test_get_acquired
traversed = traversal.publishTraverse(self.get_request, "folder")
File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/browser/traversal.py", line 40, in publishTraverse
defaultTraversal = super().publishTraverse(request, name)
File "/Users/maurits/community/plone-coredev/6.0/src/Zope/src/ZPublisher/BaseRequest.py", line 142, in publishTraverse
self.request.ensure_publishable(subobject)
AttributeError: 'NoneType' object has no attribute 'ensure_publishable'
```
|
It feels wrong to work around unittest mockup deficiencies in the "production" code. |
|
Alternative PR for dexterity: |
d-maurer
reviewed
Apr 24, 2024
There was a problem hiding this comment.
In #1202 (comment),
I proposed an alternative approach.
I favor it even though it introduces a (hopefully minor) backward incompatibility (applications can no longer influence publication control by registering their own ITraversePublisher adapter),
|
Let me close this one, there is no enthusiasm for this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen in tests.
In a Plone core development buildout with Zope master there are failures in
plone.dexterity:This could be fixed in the
plone.dexteritytests. But I expect that there will be quite a few add-ons that have their own mock request class that has noensure_publishablemethod.