-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data exports #101
Data exports #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The very last thing I'll say on this is that I think it would be better form to mock the file system interactions rather than actually building them. This is potentially premature optimization but I want to flag it and maybe create and issue to explore alternatives to disk i/o for tests.
Not blocking, nice work.
Data Exports functionality is responsible for:
AggregateMetadataFileGenerator
class), which is included in the zip file