Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 Deprecation - update dirty methods from enabled_change to saved_change_to_enabled #377

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Rails 5.1 Deprecation - update dirty methods from enabled_change to saved_change_to_enabled #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9d97e2
update subscription_preference.rb from attr_change to saved_change_to…
yuenmichelle1 Oct 22, 2024
a5f5d3b
update subscription.rb change from enabled_change to saved_change_to_…
yuenmichelle1 Oct 22, 2024
0c8c383
Merge branch 'master' into rails-5.1-deprecation-subscription_prefere…
yuenmichelle1 Oct 23, 2024
26ff7c3
Merge branch 'master' into rails-5.1-deprecation-subscription_prefere…
yuenmichelle1 Oct 23, 2024
1dbdb66
Merge branch 'master' into rails-5.1-deprecation-subscription_prefere…
yuenmichelle1 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/subscription.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class Subscription < ApplicationRecord
belongs_to :source, polymorphic: true, required: true

before_create :ensure_enabled
after_update :clear_notifications, if: ->{ enabled_change == [true, false] }
after_update :clear_notifications, if: ->{ saved_change_to_enabled == [true, false] }

validates_with SubscriptionUniquenessValidator, on: :create
scope :enabled, ->{ where enabled: true }
Expand Down
2 changes: 1 addition & 1 deletion app/models/subscription_preference.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class SubscriptionPreference < ApplicationRecord

validates :enabled, inclusion: { in: [true, false] }
scope :enabled, ->{ where enabled: true }
after_update :unsubscribe_user, if: ->{ enabled_change == [true, false] }
after_update :unsubscribe_user, if: ->{ saved_change_to_enabled == [true, false] }
validates :email_digest, inclusion: {
in: %w(immediate daily weekly never)
}
Expand Down
Loading