Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib-classifier): clean up annotation.update #6601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

Remove some unused auth code from annotation.update. Updating an annotation only needs to set the annotation value and mark it as in-progress.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifier

How to Review

The deleted lines here don’t do anything, so this shouldn’t change classifications at all.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

Remove some unused auth code from `annotation.update`. Updating an annotation only needs to set the annotation value and mark it as in-progress.
@coveralls
Copy link

Coverage Status

coverage: 77.386% (+0.03%) from 77.359%
when pulling e459d01 on eatyourgreens:patch-3
into fd585a1 on zooniverse:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants