app-project: Return active, completed workflows when project is out of data #6450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package
app-project
Linked Issue and/or Talk Post
Closes: #6188
Old corresponding PFE PR: zooniverse/Panoptes-Front-End#5394
Describe your changes
fetchWorkflowsHelper()
to first request active incomplete workflows, and if all active workflows are complete, return all active workflows for display in WorkflowSelector.subjectSets: []
from workflow object infetchWorkflowsHelper()
. The add-onsubjectSets
property is handled in each page file for/classify/workflow/[workflowId]
and not needed in the helper function, which is intended to be agnostic to whether a workflow is configured for subject set selection.fetchWorkflowsHelper.spec
for readibility.How to Review
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring