-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WildCam Lab Classrooms - 2018 Rebuild - part 4 #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shaunanoordin Thank you for the heads up to potential effects to the Astro tools. I've tested classroom PUT and I don't see any regressions. This gets a 👍 from me.
Awesome, thanks Sarah! 👌 |
…s' button more clearly now
… trying to setState in a render (it wasn't, but a refactor removed the error message anyway.)
PR UpdateThis PR has been updated with the following major changes:
StatusMerging and deploying. Please note that after this, I'll take a short break from WildCam Lab development. A "part 5" should be coming later with a focus on: 1. information pages for teachers (this is minor), 2. a students page (plus hooking up Assignments to PFE, maybe, probably), 3. a replacement for Carto (boy oh boy). |
PR Overview
This PR follows #124. In this PR, we're mostly concerned with fixing bugs that prevent the Teachers from fully enjoying the Create/Edit WildCam Assignments functionality.
Updates in place:
Planned updates:
Important: Changes Affecting Astro Classrooms
@srallen please be aware that I've updated the
/lib/edu-api.js
'sput()
function, since the pre-built request body structure wasn't flexible enough to support WildCam Classroom's PUT requests (i.e. I needed to edit the Relationship field as well as the Attributes field).The changes are as follows:
src/lib/edu-api.js
:put()
function no longer implicitly constructs the request body structure.src/ducks/classrooms.js
:put()
call now explicitly constructs the request body structure. Affects I2A's Edit Classroom functionality.src/ducks/programs.js
. ditto. Affects... er, nothing, at the moment.Side note
Sarah, since you mentioned you were making updates to I2A classrooms for summer, here are some useful notes, so you have fewer worries about your updates crossing with WildCam's functionality.
src/modules/
andsrc/programs/
.src/ducks/classrooms.js
andsrc/containers/AssignmentFormContainer.jsx
, for example, are safe to update for I2A.Status
WIP for WildCam Darien stuff.
The changes
/lib/edu-api.js
and its dependents are ready for review, @srallen .