Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WildCam Lab Classrooms - 2018 Rebuild - part 4 #125

Merged
merged 8 commits into from
Jun 6, 2018

Conversation

shaunanoordin
Copy link
Member

PR Overview

This PR follows #124. In this PR, we're mostly concerned with fixing bugs that prevent the Teachers from fully enjoying the Create/Edit WildCam Assignments functionality.

Updates in place:

  • You can actually edit WildCam Assignments. There was a bug previously that prevented data from being saved on an update. (Create Assignment continues to work fine.)

Planned updates:

  • The Assignment form should remember any data the user type into the form before they transition to the Map (to select Subjects). At this moment, if you type in an Assignment name, select subjects, then return, the Assignment name just goshdarn disappears/resets to the original.

Important: Changes Affecting Astro Classrooms

@srallen please be aware that I've updated the /lib/edu-api.js's put() function, since the pre-built request body structure wasn't flexible enough to support WildCam Classroom's PUT requests (i.e. I needed to edit the Relationship field as well as the Attributes field).

The changes are as follows:

  • src/lib/edu-api.js: put() function no longer implicitly constructs the request body structure.
  • src/ducks/classrooms.js: put() call now explicitly constructs the request body structure. Affects I2A's Edit Classroom functionality.
  • src/ducks/programs.js. ditto. Affects... er, nothing, at the moment.

Side note

Sarah, since you mentioned you were making updates to I2A classrooms for summer, here are some useful notes, so you have fewer worries about your updates crossing with WildCam's functionality.

  • Almost all the WildCam code has been moved to src/modules/ and src/programs/.
    • they don't use any I2A Classroom/Assignment-specific code; so src/ducks/classrooms.js and src/containers/AssignmentFormContainer.jsx, for example, are safe to update for I2A.
  • Only a few links to the shared code remains:
    • WildCam Classrooms still relies on the shared Join page.
      • NOTE: the Join page doesn't seem to auto-redirect students to their respective classrooms/assignments, although the join is still registered; this redirection issue seems to be present even at v1.0.0, but I haven't tested/debugged to be sure.
    • Common components like SuperDownloadButton and Status404 are still in shared use.
    • The "index" pages (src/ducks/reducer.js, ProgramHomeContainer) still have specific references to the Darien code.

Status

WIP for WildCam Darien stuff.

The changes /lib/edu-api.js and its dependents are ready for review, @srallen .

Copy link
Contributor

@srallen srallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaunanoordin Thank you for the heads up to potential effects to the Astro tools. I've tested classroom PUT and I don't see any regressions. This gets a 👍 from me.

@shaunanoordin
Copy link
Member Author

Awesome, thanks Sarah! 👌

@shaunanoordin
Copy link
Member Author

PR Update

This PR has been updated with the following major changes:

  • The Edit Assignment feature now works as intended. (There were a bunch of bugs that got fixed, such as the edited info now showing properly ont he form.)
  • UX/convenience improvements: when transitioning to/from the Assignment form and the WildCam Map (to select subjects), a lot of the data is now "remembered" so users don't have to re-type the information - the Assignment name, and any existing map filters, for example.

Status

Merging and deploying.

Please note that after this, I'll take a short break from WildCam Lab development. A "part 5" should be coming later with a focus on: 1. information pages for teachers (this is minor), 2. a students page (plus hooking up Assignments to PFE, maybe, probably), 3. a replacement for Carto (boy oh boy).

@shaunanoordin shaunanoordin merged commit 7543c2e into master Jun 6, 2018
@shaunanoordin shaunanoordin deleted the wildcam-2018-pt4 branch July 2, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants