Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed HDBSCAN to use scikit-learn's version.
Previously the HDBSCAN clustering algorithm was implemented using a mostly redundant package (simply called HDBSCAN), which has now been incorporated into scikit-learn. By making this change, less packages are needed, reducing the chance of dependency conflicts. E.g. the original HDBSCAN has issues with the version of numpy and compiling its own Cython code.
As the scikit-learn's HDBSCAN uses the same input format as the other algorithms in the clustering module, some of the unit tests have been changed. The most significant change is
cluster _persistence
is no longer available.Both manual and unit tests have shown minimal changes to the clusters found. Only in one case did the unit test need to change, as the cluster labelling had changed for the same clusters found.
Finally, the
condensed_tree_.plot
is no longer available. Therefore the notebook How_Clustering_Works.ipynb was changed to use static .png images to explain the HDBSCAN algorithm. Some minor typos were also fixed.