Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build banner on signed-in homepage #7158

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Build banner on signed-in homepage #7158

merged 3 commits into from
Sep 10, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Aug 22, 2024 •
edited
Loading

Staging branch URL: https://pr-7158.pfe-preview.zooniverse.org

Describe your changes.

  • Build a banner on the signed-in homepage as per communications plan for new FEM pages launch.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?

@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Coverage Status

coverage: 56.845%. remained the same
when pulling 1d6ac91 on signed-in-home-banner
into c23b44c on master.

@goplayoutside3 goplayoutside3 marked this pull request as ready for review September 5, 2024 20:45
@mcbouslog mcbouslog self-assigned this Sep 6, 2024
mcbouslog
mcbouslog approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward message looks good 👍 . Styling works on desktop through mobile widths.

@mcbouslog mcbouslog removed their assignment Sep 9, 2024
@goplayoutside3 goplayoutside3 self-assigned this Sep 10, 2024
@goplayoutside3 goplayoutside3 merged commit cc45151 into master Sep 10, 2024
5 checks passed
@goplayoutside3 goplayoutside3 deleted the signed-in-home-banner branch September 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

Assignees

@goplayoutside3 goplayoutside3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goplayoutside3 @coveralls @mcbouslog