-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lab): clear references to a task key after deleting a task #7099
base: master
Are you sure you want to change the base?
Conversation
ae4b83b
to
ff0d887
Compare
Both the new function and its test were written almost entirely by Copilot. It needs supervision, but seems to be very good at small tasks like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request: changes to app/pages/lab/workflow.jsx
should also be replicated, if possible, on app/pages/lab-fem/workflow.jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and rebased to the latest changes on the main branch.
1f56921
to
025591b
Compare
c1b489d
to
b313d3b
Compare
b313d3b
to
f91cabe
Compare
f91cabe
to
ed0942f
Compare
A small helper function which iterates through `workflow.tasks` and deletes references to a given task key. It's called after deleting a task, so that other tasks no longer link to the deleted task.
ed0942f
to
61a99e0
Compare
A small helper function which iterates through
workflow.tasks
and deletes references to a given task key. It's called after deleting a task, so that other tasks no longer link to the deleted task.Required Manual Testing
Review Checklist
npm ci
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?