Rewording and provide new URL path /run-test instead of /check (former /domain_check)
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mattias-p,
matsduf,
hannaeko,
tgreenx and
marc-vanderwal
marc-vanderwal
previously approved these changes
Sep 22, 2022
matsduf
reviewed
Sep 22, 2022
matsduf
reviewed
Sep 22, 2022
Yes, when this is merge we should create an issue for translation. |
matsduf
requested changes
Sep 22, 2022
ghost
added
the
V-Minor
|
Rebased on top of develop to fix a conflict. |
matsduf
requested changes
Nov 18, 2022
tgreenx
previously approved these changes
Nov 22, 2022
matsduf
previously approved these changes
Nov 23, 2022
|
rebased on top of develop, please re-review |
matsduf
previously approved these changes
Nov 23, 2022
tgreenx
previously approved these changes
Nov 24, 2022
* API: move `check` to `run-test` * UI: update strings refering to "domain check" to "run test" * adapt e2e tests
added 7 commits
November 25, 2022 10:50
* with the drop of the "domain check" wording, components are also renamed to be more generic. * harmonize use of Camel case
matsduf
approved these changes
Nov 25, 2022
tgreenx
added
the
S-ReleaseTested
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Take into consideration reviews and suggestions in meeting and partially from #333 (comment).
Mainly this is about rewording menu entry and everything around the "Domain check" words. This PR goes a little bit further with a code refactoring to reflect such changes.
This PR is to be merged before #333. Conflicts will be resolved in #333.
Context
#333 and meeting discussion
updates #334
Changes
/run-test,/run-test/<domain>, "Run test", "Run domain test".How to test this PR
Tests should pass.