-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There a lot of thing has been update by krisklosterman #128
base: master
Are you sure you want to change the base?
Conversation
I wouldn't merge this one, you are changing the package. Now zone117x/node-multi-hashing.git is used, and you are changing it to one of your own.. |
Hi, can you add M7 algo? |
this PR contains a lot of updates which actually make sense and I wanted to do anyways. so we gonna merge this and revert the changes with issues, that way is simpler than cherry-picking all the useful stuff. |
You'll probably want to change the bignum library too then. I recommend https://github.com/MikeMcl/bignumber.js, that's the one I'm using on my version. Excellent support from the author too. |
@MueR I was indeed thinking about that. The one you are suggesting might be lightweight but does not cover the necessary precision for all use cases. |
I've converted everything to run on the 8.11 LTS version, using full ES2017 features. Just about everything is in javascript modules now. I've not found any problems with bignumber.js so far, but maybe I'm missing something? |
If I had the time I would aim to support latest LTS and latest stable. Just don't have the time to implement or vet the changes. Would really appreciate it if @MueR did a pull request for the updates and @HashUnlimited could help review them. |
I'll have to see if I can find some time this week @zone117x and @HashUnlimited. I've done a bit more than just rewrite everything into modules, I've also added some proprietary things that I'm not willing to share readily. But I'll see about filtering some of the custom work out soonish. |
Dears,
Could you approve PR request? krisklosterman has been update and changed many things.
Regards,
John Ahn