safer file content hash handling

zone-eu · Sep 16, 2024 · daa9767 · daa9767
1 parent 6515b27
commit daa9767
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/lib/attachments/gridstore-storage.js b/lib/attachments/gridstore-storage.js
@@ -142,19 +142,21 @@ class GridstoreStorage {
                         if (args.length > 2) {
                             const calculatedFileContentHash = args[2];
 
-                            this.gridfs.collection(this.bucketName + '.files').findOneAndUpdate(
-                                {
-                                    _id: hash
-                                },
-                                {
-                                    $set: {
-                                        'metadata.fileContentHash': calculatedFileContentHash
+                            if (calculatedFileContentHash) {
+                                this.gridfs.collection(this.bucketName + '.files').findOneAndUpdate(
+                                    {
+                                        _id: hash
+                                    },
+                                    {
+                                        $set: {
+                                            'metadata.fileContentHash': calculatedFileContentHash
+                                        }
+                                    },
+                                    {
+                                        returnDocument: 'after'
                                     }
-                                },
-                                {
-                                    returnDocument: 'after'
-                                }
-                            );
+                                );
+                            }
                         }
                         callback(...args);
                     });