Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thor's deprecation error #195

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

udaykadaboina
Copy link
Contributor

Thor 1.0.0(CHANGELOG) has deprecated the behavior of relying on default exit_on_failure? Hence, making the devs define this method.

Thor #621, #625

PRIOR TO CHANGE:

bundle exec derailed exec perf:mem_over_time development
ERROR: "derailed exec" was called with arguments ["perf:mem_over_time", "development"]
Usage: "derailed exec"
Deprecation warning: Thor exit with status 0 on errors. To keep this behavior, you must define `exit_on_failure?` in `DerailedBenchmarkCLI`
You can silence deprecations warning by setting the environment variable THOR_SILENCE_DEPRECATION.

AFTER:

bundle exec derailed exec perf:mem_over_time development
ERROR: "derailed exec" was called with arguments ["perf:mem_over_time", "development"]
Usage: "derailed exec"

@schneems
Copy link
Member

schneems commented Jun 8, 2021

Hi, thanks for the PR this looks great. Can you add a changelog entry and then rebase? https://www.codetriage.com/rebase

@udaykadaboina
Copy link
Contributor Author

Hi @schneems let me know how it looks.

@schneems schneems merged commit 887f174 into zombocom:main Jun 8, 2021
@schneems
Copy link
Member

schneems commented Jun 8, 2021

Thanks!

@udaykadaboina udaykadaboina deleted the fix-thor-deprecation branch June 11, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants