Do not warn agents about empty article subjects by default (#88). #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When an agent wants to reply to a ticket, they get a warning about empty article subjects when the mail only contains the ticket hook. This is annoying as the subject usually doesn't contain only the ticket hook.
This change implements a new subaction for AgentTicketCompose where the subject is checked. And in the JavaScript code this subaction is called when the dialog is opened and when the subject is changed. And the warning is shown when TicketSubjectClean() returns an empty subject (and the new subaction returns a value that the subject would be empty).
This new subaction has the nice effect, that a solution for znuny/znuny-feature-requests#19 would be recognized as well without any further code change.
Type of change
Additional information
Checklist