Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(codes): Android Support: Basic Controls and Input + Display #603

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

KingCoinless
Copy link
Contributor

Android version/build?

Android 10

What codes did you test?

C_BRI_UP
C_BRI_DN
C_BRI_MIN
C_BRI_MAX
C_BRI_AUTO
C_BKLT_TOG
C_ASPECT
C_SLOW
C_SLOW2
C_SNAPSHOT
LANG2

How did you test?

Manual use with my Helix split keyboard using the associated ZMK shield. Typed in a note file and browser when testing LANG2 functionality. Used the “Play Music”, “Vanilla Music”, and ‘YouTube’ apps for testing C_SLOW and C_SLOW2.

Have you any useful information?

Most of these commands do not work in Android. C_SNAPSHOT switches to the camera and takes a picture. I could only use C_BRI_UP, and not other brightness options. Contrary to existing documentation, LANG2 was fully functional for me as a language toggle between English and Japanese input.

Has anyone else tested/verified it?

Only LANG2 has been tested and marked as non-functional. My results concluded that LANG2 was in fact usable in Android for switching between Japanese and English input (like a toggle), contradicting existing docs.

@innovaker innovaker added the documentation Improvements or additions to documentation label Jan 15, 2021
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me based on the code changes and the deploy preview. I have not personally tested the keycodes on Android.

@@ -5184,7 +5184,7 @@ export default [
os: {
windows: null,
linux: true,
android: null,
android: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we seek a second verification for this one before listing C_BRIGHTNESS_DEC as unsupported on Android?

It seems strange that C_BRIGHTNESS_INC does work but not C_BRIGHTNESS_DEC.

I noticed in #600 (comment) that C_BRIGHTNESS_DEC didn't work for Windows during initial testing a year ago, but that it did work in subsequent testing more recently. (So perhaps something changed under the hood that may have resolved this?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems reasonable to me to have someone check this. If someone wants to test it and confirm this functionality, I'll commit a suggested change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, on Android 10 neither C_BRIGHTNESS_INC nor C_BRIGHTNESS_DEC work for me.

@petejohanson
Copy link
Contributor

Can we retest this w/ the latest consumer page refactors?

docs/src/data/hid.js Outdated Show resolved Hide resolved
docs/src/data/hid.js Outdated Show resolved Hide resolved
@Nick-Munnich
Copy link
Contributor

Tested and found C_BRIGHTNESS_INC, C_BRIGHTNESS_DEC, C_SNAPSHOT to be working, while all others are not working.

@Nick-Munnich Nick-Munnich requested a review from a team as a code owner October 20, 2024 21:51
@Nick-Munnich Nick-Munnich merged commit 7293037 into zmkfirmware:main Oct 20, 2024
7 checks passed
lammai pushed a commit to lammai/zmk that referenced this pull request Oct 27, 2024
…firmware#603)

* docs(codes): Android Support: Basic Controls and Input + Display
---------

Co-authored-by: Nicolas Munnich <[email protected]>
EnotionZ pushed a commit to EnotionZ/zmk that referenced this pull request Nov 6, 2024
…firmware#603)

* docs(codes): Android Support: Basic Controls and Input + Display
---------

Co-authored-by: Nicolas Munnich <[email protected]>
earwin pushed a commit to earwin/zmk that referenced this pull request Nov 13, 2024
…firmware#603)

* docs(codes): Android Support: Basic Controls and Input + Display
---------

Co-authored-by: Nicolas Munnich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants