-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(codes): Android Support: Basic Controls and Input + Display #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me based on the code changes and the deploy preview. I have not personally tested the keycodes on Android.
docs/src/data/hid.js
Outdated
@@ -5184,7 +5184,7 @@ export default [ | |||
os: { | |||
windows: null, | |||
linux: true, | |||
android: null, | |||
android: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we seek a second verification for this one before listing C_BRIGHTNESS_DEC
as unsupported on Android?
It seems strange that C_BRIGHTNESS_INC
does work but not C_BRIGHTNESS_DEC
.
I noticed in #600 (comment) that C_BRIGHTNESS_DEC
didn't work for Windows during initial testing a year ago, but that it did work in subsequent testing more recently. (So perhaps something changed under the hood that may have resolved this?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also seems reasonable to me to have someone check this. If someone wants to test it and confirm this functionality, I'll commit a suggested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, on Android 10 neither C_BRIGHTNESS_INC
nor C_BRIGHTNESS_DEC
work for me.
Can we retest this w/ the latest consumer page refactors? |
Tested and found C_BRIGHTNESS_INC, C_BRIGHTNESS_DEC, C_SNAPSHOT to be working, while all others are not working. |
…firmware#603) * docs(codes): Android Support: Basic Controls and Input + Display --------- Co-authored-by: Nicolas Munnich <[email protected]>
…firmware#603) * docs(codes): Android Support: Basic Controls and Input + Display --------- Co-authored-by: Nicolas Munnich <[email protected]>
…firmware#603) * docs(codes): Android Support: Basic Controls and Input + Display --------- Co-authored-by: Nicolas Munnich <[email protected]>
Android version/build?
Android 10
What codes did you test?
C_BRI_UP
C_BRI_DN
C_BRI_MIN
C_BRI_MAX
C_BRI_AUTO
C_BKLT_TOG
C_ASPECT
C_SLOW
C_SLOW2
C_SNAPSHOT
LANG2
How did you test?
Manual use with my Helix split keyboard using the associated ZMK shield. Typed in a note file and browser when testing
LANG2
functionality. Used the “Play Music”, “Vanilla Music”, and ‘YouTube’ apps for testingC_SLOW
andC_SLOW2
.Have you any useful information?
Most of these commands do not work in Android.
C_SNAPSHOT
switches to the camera and takes a picture. I could only useC_BRI_UP
, and not other brightness options. Contrary to existing documentation,LANG2
was fully functional for me as a language toggle between English and Japanese input.Has anyone else tested/verified it?
Only
LANG2
has been tested and marked as non-functional. My results concluded that LANG2 was in fact usable in Android for switching between Japanese and English input (like a toggle), contradicting existing docs.