Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Make physical layout key rotation optional #2770

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Jan 15, 2025

To be able to save on flash space, for layouts on space constrained devices that don't require rotation, make key rotation props optional behind a new Kconfig flag.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

To be able to save on flash space, for layouts on space constrained
devices that don't require rotation, make key rotation props
optional behind a new Kconfig flag.
@petejohanson petejohanson added enhancement New feature or request refactor studio ZMK Studio (runtime keymaps) labels Jan 15, 2025
@petejohanson petejohanson self-assigned this Jan 15, 2025
@petejohanson petejohanson requested review from a team as code owners January 15, 2025 17:52
@petejohanson petejohanson merged commit c367d8f into zmkfirmware:main Jan 15, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor studio ZMK Studio (runtime keymaps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants