-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rgb animation refactor #2736
Open
Sapphirewhale
wants to merge
10
commits into
zmkfirmware:main
Choose a base branch
from
Sapphirewhale:feature/rgb-animation-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/rgb animation refactor #2736
Sapphirewhale
wants to merge
10
commits into
zmkfirmware:main
from
Sapphirewhale:feature/rgb-animation-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts the rgb_underglow_effect enum into a struct, allowing for new effects to be added without the need for a new case statement and enum value
Allows underglow effects to provide a callback to be triggered whenever a key is pressed on the keyboard. This allows for the building of underglow effects that react to key presses.
Adds an underglow transform dts binding, which defines a mapping from physical positions to underglow pixel indexes, allowing developers to identify the index for the LED which corresponds to a given keypress, and generally place LEDs from the strip in physical space.
Adds functions and values to be used in animated and reactive rgb underglow effects
Adds functionality to disable and enable ext power based on whether any LEDs are currently active.
Removing duplicate underglow effects list (whoops)
Adds a new underglow effect simulating symbols scrolling down the keyboard columns similar to the code monitors from the matrix.
Adds a new underglow effect which turns on the LED underneath each key with a random color whenever they are pressed, then gradually fades them out
Adds a new underglow effect simulating a ripple of light emanating from any pressed key.
I'm afraid that this comment of mine also applies here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! This is my first time contributing to this repo (also first time working on an OS, and first time writing C since uni), so feel free to let me know if you have any feedback on the code or PR. Here's the summary of my changes:
Tested on a glove80 with both this repo and the version written from the moergo-sc fork.
I did write this all in the hopes that it would work out of the box on a different keyboard, but I don't have one available to test with, so if you're feeling up to writing up the underglow transform and testing it on your own board, feel free to let me know if you have any issues and I can try to fix it up.
The effects I've added are things that I figured would help break down my testing, and that I personally enjoyed, but I'm happy to break them out into a separate PR or remove them entirely, my main goal was to make this code easier to modify for anyone else in the community with fun ideas for LED effects.
The ripple effect was the main effect I wanted to implement, but I'm afraid that it's not especially performant, if you have the time and motivation to work out what's causing that and fix it I would greatly appreciate it.
I'm also happy to write up some basic documentation on how to add effects and use some of the utility functions if anyone could point me to a good spot in the docs.
PR check-list