-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running tests from anywhere and support EXTRA_MODULES #2725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Since this didn't opt to run tests, can you please add this file to the paths
in .github/workflows/test.yml
file so it'll run tests, and run them next time we have a PR to change this file?
TIA!
Done! I tested backward-compatibility locally but was wondering why the GHA suite didn't run. You might want to manually check that |
Still working fine. I added some garbage to the test snaphshot, then ran the follow sequence:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…mkfirmware#2725) * Allow running tests from anywhere in the workspace * Trigger test workflow if run-test.sh changes
…mkfirmware#2725) * Allow running tests from anywhere in the workspace * Trigger test workflow if run-test.sh changes
This includes a few tweaks to
run-tests.sh
ZMK_SRC_DIR
andZMK_BUILD_DIR
pathsZMK_EXTRA_MODULES
app/run-tests.sh
or/workspace/zmk/app/run-tests.sh
)app/tests/gresc
or/workspace/zmk/app/tests/gresc
, or evengresc
if we are in.../tests
)ZMK_SRC_DIR
,ZMK_BUILD_DIR
andZMK_EXTRA_MODULES
Being able to run tests from anywhere in the workspace is mostly a quality-of-life improvement. The real application is to test modules without having to re-invent the wheel.
For instance, suppose the working directory is the root of a workspace with the following structure:
Then one could run the module tests as follows:
PR check-list