Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointing): Complete header rename missed in refactor #2702

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

petejohanson
Copy link
Contributor

  • Update a few mouse.h -> pointing.h missed refactors.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.

@petejohanson petejohanson added bug Something isn't working pointers Pointer related functionality labels Dec 10, 2024
@petejohanson petejohanson self-assigned this Dec 10, 2024
@petejohanson petejohanson requested review from a team as code owners December 10, 2024 07:03
@caksoylar
Copy link
Contributor

There's also a non-renamed Kconfig in

if you want to add onto this.

* Update a few mouse.h -> pointing.h missed refactors.
@petejohanson
Copy link
Contributor Author

There's also a non-renamed Kconfig in


if you want to add onto this.

Ironically, I had changed this to test that our backwards compat for that symbol worked... and forgot to change it back. Good catch. Thanks.

@petejohanson petejohanson merged commit 84baf92 into zmkfirmware:main Dec 10, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pointers Pointer related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants