Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): Add numpad layouts #2574

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

joelspadin
Copy link
Collaborator

Added physical layouts for the following variants of numpads:

  • With and without extra top row
  • 2U plus key or 1U plus and backspace keys
  • 2U 0 key or 1U 0 and 00 keys
  • Full 1U grid/macropad layout

Other layouts exist, such as "southpaw" horizontally mirrored layouts, and layouts with a fifth column, but those seem to be much less common. There are a lot of layouts here already, so we can add the less common ones later if anyone asks for them.

Added physical layouts for the following variants of numpads:

- With and without extra top row
- 2U plus key or 1U plus and backspace keys
- 2U 0 key or 1U 0 and 00 keys
- Full 1U grid/macropad layout

Other layouts exist, such as "southpaw" horizontally mirrored layouts,
and layouts with a fifth column, but those seem to be much less common.
@joelspadin joelspadin requested a review from a team as a code owner October 20, 2024 05:37
@Nick-Munnich
Copy link
Contributor

LGTM

@caksoylar caksoylar added the studio ZMK Studio (runtime keymaps) label Oct 27, 2024
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit cf2c467 into zmkfirmware:main Nov 6, 2024
22 checks passed
@joelspadin joelspadin deleted the numpad-layouts branch November 9, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
studio ZMK Studio (runtime keymaps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants