Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about .keymap changes when using Studio #2558

Conversation

petejohanson
Copy link
Contributor

No description provided.

@petejohanson petejohanson added documentation Improvements or additions to documentation studio ZMK Studio (runtime keymaps) labels Oct 16, 2024
@petejohanson petejohanson self-assigned this Oct 16, 2024
@petejohanson petejohanson requested a review from a team as a code owner October 16, 2024 16:17
@@ -14,6 +14,12 @@ ZMK Studio provides runtime update functionality to ZMK powered devices, allowin

To unlock your keyboard to allow ZMK Studio to make changes, you'll need to add a [`&studio_unlock`](../keymaps/behaviors/studio-unlock.md) binding to the keymap.

:::note

Once using ZMK Studio to manage your keymap, any future changes made to the `.keymap` file for your keyboard will not be applied unless you perform a "Restore Stock Settings" action from the ZMK Studio UI. Generally, if you intend to use ZMK Studio, then you should not make any further changes to the `.keymap` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once using ZMK Studio to manage your keymap, any future changes made to the `.keymap` file for your keyboard will not be applied unless you perform a "Restore Stock Settings" action from the ZMK Studio UI. Generally, if you intend to use ZMK Studio, then you should not make any further changes to the `.keymap` file.
Once using ZMK Studio to manage your keymap, any future changes made to the `.keymap` file for your keyboard will not be applied unless you perform a "Restore Stock Settings" action from the ZMK Studio UI.
Generally, if you intend to use ZMK Studio, then (aside from adding additional empty layers when necessary) you should not make any further changes to the `.keymap` file.

Feel free to rephrase, just thought this ought to be mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding that at the end of the sentence reads better than in the middle. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly matches the flow of the sentence better, I just couldn't think of a good phrasing off the top of my head for that way round.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on the updated version?

@petejohanson petejohanson force-pushed the studio/note-that-dot-keymap-changes-wont-apply branch from 9c921a8 to e4fd3f3 Compare October 16, 2024 18:31
@petejohanson petejohanson merged commit c8841c4 into zmkfirmware:main Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation studio ZMK Studio (runtime keymaps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants