Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos in various places #2290

Merged
merged 3 commits into from
May 13, 2024
Merged

chore: fix typos in various places #2290

merged 3 commits into from
May 13, 2024

Conversation

HigherOrderLogic
Copy link
Contributor

No description provided.

@HigherOrderLogic HigherOrderLogic requested a review from a team as a code owner May 2, 2024 14:03
caksoylar
caksoylar approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, docs changes (and others, too) LGTM. All other changes are in Kconfig/yml descriptions or code comments, so should be safe to merge, but I'll leave it to the core maintainers.

petejohanson
petejohanson approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good catches. Thanks!

@petejohanson petejohanson merged commit 7d1f84e into zmkfirmware:main May 13, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caksoylar caksoylar caksoylar approved these changes

@petejohanson petejohanson petejohanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HigherOrderLogic @petejohanson @caksoylar