fix(usb): Tweak how ZMK_USB gets enabled. #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
changed the title
petejohanson
force-pushed
the
config/defaults-for-hid-outputs-fixes
branch
from
3194035 to
74051f1
Compare
* Previous version of multiple overrides of the default value of ZMK_USB were problematic. Move to using board _defconfig files for the defaults for those, along with proper `depends on` for ZMK_USB that accounts for split and split roles.
petejohanson
force-pushed
the
config/defaults-for-hid-outputs-fixes
branch
from
74051f1 to
cc8c048
Compare
This was referenced Nov 13, 2023
|
Many of the tests are green, and this is hitting production split builds, so merging this to stem the pain. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends onfor ZMK_USB that accounts for split and split roles.This addresses a current build failure in ZMK main when building for a controller like proton-c with a split right side. Although not important now, this should get cleaned up in preparation for eventual wired split support. See an example failure here: https://github.com/zmkfirmware/zmk/actions/runs/6853902894/job/18635806769