EXPERIMENTAL: Zephyr 3.4 update #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
core
petejohanson
force-pushed
the
core/zephyr-3.4-update
branch
from
20e87d9 to
c0dc4e9
Compare
mike1808
reviewed
Jun 28, 2023
| @@ -72,7 +72,7 @@ void wpm_expiry_function() { k_work_submit(&wpm_work); } | |||
|
|
|||
| K_TIMER_DEFINE(wpm_timer, wpm_expiry_function, NULL); | |||
|
|
|||
| int wpm_init() { | |||
| static int wpm_init(void) { | |||
There was a problem hiding this comment.
For consistency, it should have been static in the first place, it doesn't need to be an exported public symbol.
|
flashed my keyboard with it, the only issue i noticed is that my central side sharp memory display was not working, no errors in the log. I'll try to see why they don't work later. |
chrissicool
reviewed
Jul 10, 2023
| @@ -74,8 +74,8 @@ void activity_work_handler(struct k_work *work) { | |||
| } else | |||
| #endif /* IS_ENABLED(CONFIG_ZMK_SLEEP) */ | |||
| if (inactive_time > MAX_IDLE_MS) { | |||
| set_state(ZMK_ACTIVITY_IDLE); | |||
| } | |||
| set_state(ZMK_ACTIVITY_IDLE); | |||
There was a problem hiding this comment.
The indentation looks messed up here.
petejohanson
force-pushed
the
core/zephyr-3.4-update
branch
from
d3205ea to
b4dc54e
Compare
|
I think I found two more LV_Z_DPI symbols that can be changed: |
petejohanson
force-pushed
the
core/zephyr-3.4-update
branch
from
b4dc54e to
55565b2
Compare
* Upstream added an equivalent fuel gauge driver, so namespace our Kconfig symbol for the MAX17048 driver.
|
Note for Zephyr 3.5: Previously SPI3 could be defined with the MOSI pin and nothing else when configuring WS2812B. Zephyr 3.5 seems to require a dummy SCK pin on SPI3 (just like how it was necessary for SPI0/SPI1/SPI2). |
|
Superseded by #1995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder for now, so folks who have reported BLE issues on Windows in particular can test latest Zephyr BLE stack and see if this improves things.
This has not gotten extensive testing yet, and should be considered highly experimental.