func (a Authenticator) Token() more portable #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I appreciate all the work that's gone into this pkg, and this PR helps make it more a little more reusable.
This PR makes
func (a Authenticator) Token()
now takes the redirected URL rather than ahttp.Request
(which assumes Go was used as a server to receive the redirect and makes less sense to pass in).It's either this or also add a
http.Request
variant offunc (a Authenticator) Token()
to other calls to have to be changed, but I think it makes more sense to take in the URL than the reader.