Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func (a Authenticator) Token() more portable #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drew-512
Copy link

Hi! I appreciate all the work that's gone into this pkg, and this PR helps make it more a little more reusable.

This PR makes func (a Authenticator) Token() now takes the redirected URL rather than a http.Request (which assumes Go was used as a server to receive the redirect and makes less sense to pass in).

It's either this or also add a http.Request variant of func (a Authenticator) Token() to other calls to have to be changed, but I think it makes more sense to take in the URL than the reader.

@drew-512
Copy link
Author

For example, in our project, we get the redirect URL pass to us as a string, so func (a Authenticator) Token() is not usable if it only accepts a http.Request to pull the URL from.

@strideynet strideynet self-requested a review May 27, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant