Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created ordered list for HTTP headers #313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nakulbajaj
Copy link

Modified ZGrab2's HTTP package to extract headers as a list of
HeaderField objects and then extract as a map via the textproto package.

Created new HeaderField object with UTF-8 string for header names
paired with a byte slice for header values.

Modified ZGrab2's HTTP package to extract headers as a list of
HeaderField objects and then extract as a map via the textproto package.

Created new HeaderField object with UTF-8 string for header names
paired with a byte slice for header values.
@nakulbajaj nakulbajaj marked this pull request as ready for review June 4, 2021 18:27
@mzpqnxow
Copy link
Contributor

mzpqnxow commented Jun 21, 2021

@nakulbajaj does this change how the headers are represented in the NDJSON output?

(Aside from ordering, of course)

@nakulbajaj
Copy link
Author

@mzpqnxow This doesn't change the "headers" dictionary as part of the JSON output at all. Instead, it creates a new field in the JSON output called "header_list," which composed of a list of header objects (which include a name and a value string).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants