Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update structure #90

Merged
merged 8 commits into from
Aug 27, 2024
Merged

feat: update structure #90

merged 8 commits into from
Aug 27, 2024

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented Aug 27, 2024

Description

  • Update @nuxt/eslint to 0.5.3 to fix some eslint flat config errors. Restart your ESLint Server via VSCode panel or VSCode itself to get eslint working again.
  • Add a "category" for paths to help group content for algolia search.
  • Update the DOM for the page layout to help with algolia search crawling.
  • Major readjustment to the pages to improve paths. Folders should have a index.md so that URLs that go to a folder path like /js/ethers/api have a page to default to for the API folder. Primarily for SEO, linking, and breadcrumbs.

The main thing to review is the page layout component: https://github.com/zksync-sdk/sdk-docs/compare/update-structure?expand=1#diff-575d0b4cf7e94b73d7e421f4482180f1832f172bfef28701cf37a48f51d2a17d and the useCategory composable: https://github.com/zksync-sdk/sdk-docs/compare/update-structure?expand=1#diff-289f43ba82dae8afff0e3bd22ebfe1fb5c982ed37b483c2918cc1a8071930cbb

@itsacoyote itsacoyote requested a review from jennyg0 August 27, 2024 15:21
@itsacoyote itsacoyote changed the title Update structure feat: update structure Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

Visit the preview URL for this PR (updated for commit d5a8f27):

https://zksync-sdk-docs-staging--pr90-update-structure-yddkbskh.web.app

(expires Tue, 03 Sep 2024 18:18:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6539d831ccfa61081c09db66b409eadb94db989

@itsacoyote itsacoyote marked this pull request as ready for review August 27, 2024 16:08
@itsacoyote itsacoyote requested review from a team as code owners August 27, 2024 16:08
jennyg0
jennyg0 previously approved these changes Aug 27, 2024
@itsacoyote itsacoyote merged commit 7fcee4c into main Aug 27, 2024
9 checks passed
@itsacoyote itsacoyote deleted the update-structure branch August 27, 2024 18:45
Copy link

🎉 This issue has been resolved in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants