-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update structure #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some additional DOM structure to help with Algolia docsearch crawling.
Visit the preview URL for this PR (updated for commit d5a8f27): https://zksync-sdk-docs-staging--pr90-update-structure-yddkbskh.web.app (expires Tue, 03 Sep 2024 18:18:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f6539d831ccfa61081c09db66b409eadb94db989 |
jennyg0
previously approved these changes
Aug 27, 2024
jennyg0
approved these changes
Aug 27, 2024
🎉 This issue has been resolved in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
index.md
so that URLs that go to a folder path like/js/ethers/api
have a page to default to for the API folder. Primarily for SEO, linking, and breadcrumbs.The main thing to review is the page layout component: https://github.com/zksync-sdk/sdk-docs/compare/update-structure?expand=1#diff-575d0b4cf7e94b73d7e421f4482180f1832f172bfef28701cf37a48f51d2a17d and the useCategory composable: https://github.com/zksync-sdk/sdk-docs/compare/update-structure?expand=1#diff-289f43ba82dae8afff0e3bd22ebfe1fb5c982ed37b483c2918cc1a8071930cbb