Implement FRI committed layers #19
Conversation
| .collect() | ||
| } | ||
|
|
||
| fn clone_arc(&self) -> Arc<dyn FriLayer<F, E>> { |
There was a problem hiding this comment.
Why is this method needed? Can't the user just wrap the thing in an Arc himself?
This also copies the underlying struct, I would imagine that the goal was to have a number of references to the same immutable instance?
There was a problem hiding this comment.
Yes, removed this function.
| Arc::new(FriLayerProxy { | ||
| layer_size: self.layer_size, | ||
| domain: self.domain, | ||
| prev_layer: Arc::clone(&self.prev_layer), |
There was a problem hiding this comment.
self.prev_layer.clone() does the same.
There was a problem hiding this comment.
Removed the clone_arc function.
|
|
||
| #[derive(Clone)] | ||
| pub struct FriLayerReal<F: PrimeField, E: EvaluationDomain<F>> { | ||
| layer_size: usize, |
There was a problem hiding this comment.
layer_size is a redundant field: it looks to be the same as domain.size()?
There was a problem hiding this comment.
Removed layer_size.
| } | ||
| } | ||
|
|
||
| pub fn new_from_prev_layer(prev_layer: &dyn FriLayer<F, E>) -> Self { |
There was a problem hiding this comment.
This just clones the layer?
There was a problem hiding this comment.
It is used to create FriLayerReal from the previous FriLayerProxy, both the structs implement FriLayer trait.
|
Closing this PR since #24 is merged. |
Implements FRI layers and committed layers corresponding to the following Stone library:
https://github.com/starkware-libs/stone-prover/tree/main/src/starkware/fri
This PR has dependency on #18.