helpers: make params of input helpers optional when body is ignored

zkemail · Apr 1, 2024 · e042932 · e042932
1 parent 0d0a7ea
commit e042932
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/packages/helpers/package.json b/packages/helpers/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@zk-email/helpers",
-  "version": "3.2.2",
+  "version": "3.2.3",
   "main": "dist",
   "scripts": {
     "build": "tsc",

diff --git a/packages/helpers/src/input-helpers.ts b/packages/helpers/src/input-helpers.ts
@@ -115,14 +115,14 @@ type CircuitInput = {
 };
 
 export function generateCircuitInputs(params: {
-  body: Buffer;
   message: Buffer;
-  bodyHash: string;
   rsaSignature: BigInt;
   rsaPublicKey: BigInt;
+  body?: Buffer;
+  bodyHash?: string;
   shaPrecomputeSelector?: string;
-  maxMessageLength: number;
-  maxBodyLength: number;
+  maxMessageLength?: number;
+  maxBodyLength?: number;
   ignoreBodyHashCheck?: boolean;
 }): CircuitInput {
   const {
@@ -151,6 +151,12 @@ export function generateCircuitInputs(params: {
   };
 
   if (!ignoreBodyHashCheck) {
+    if (!body || !bodyHash) {
+      throw new Error(
+        `body and bodyHash are required when ignoreBodyHashCheck is false`
+      );
+    }
+
     const bodyHashIndex = message.toString().indexOf(bodyHash);
 
     // 65 comes from the 64 at the end and the 1 bit in the start, then 63 comes from the formula to round it up to the nearest 64.