Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler API WIP #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Profiler API WIP #24

wants to merge 1 commit into from

Conversation

ebfull
Copy link
Collaborator

@ebfull ebfull commented Jun 23, 2018

WIP

This is to address #19 and any similar benchmarking and information collection.

The idea is that the concrete ConstraintSystem should provide a .profiler() method that returns a reference to a generic Profiler. Inside of synthesis, we'll have some kind of interface for benchmarking witnessing, but I haven't figured out how that should look yet. (It can probably partially piggyback on top of the existing namespacing!)

Anyway, the outer object should have some way to communicate information such as:

  1. How many constraints were created?
  2. How many public inputs and auxillary variables are there?
  3. How long did witness generation take in total? (Note that any profiling inside of witness generation might produce overhead that this wouldn't know about. This and other things make me think there should be layers to the profiler abstraction, such as a subtrait that deals with profiling witness generation?)

str4d pushed a commit that referenced this pull request Aug 25, 2020
Even more adjustments

Closes #22
Closes #24
Closes #25
str4d pushed a commit that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant