Merge(SuitApply):合并正装借用，修复部分 bug #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j10ccc
reviewed
Jul 3, 2024
Comment on lines
+82
to
+89
| run({ | ||
| iid: iid.value, | ||
| stuid: stuid.value, | ||
| password: password.value | ||
| }); | ||
| }; | ||
|
|
||
| const { run } = useRequest( |
Comment on lines
+82
to
+89
| run({ | ||
| iid: iid.value, | ||
| stuid: stuid.value, | ||
| password: password.value | ||
| }); | ||
| }; | ||
|
|
||
| const { run } = useRequest( |
There was a problem hiding this comment.
useRequest 如果没声明 config.manual = true，应该会在组件挂载的时候发送一次请求。你这里的请求函数从名字上看是用来修改密码，那不应该自动发送请求才对。你得显式传入个 manual。
如果不需要挂载的时候触发请求，不需要渲染请求的结果，不需要拿到请求的 loading 状态，那没必要用 useRequest， 直接调用 Service 下的函数就行
|
因为版本推送需要暂时merge,后续会优化这段代码 |
|
@xixiIBN5100 让现在的开发人员注意一下 useRequest 的使用，注意我说的点，另外直接调用暴露出的 run，也不设个别名，这样太不合理了 |
收到，感谢指正 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.