Skip to content

chore: release v3.0.0 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Pr0methean
Copy link
Member

@Pr0methean Pr0methean commented May 12, 2025

πŸ€– New release

  • zip: 2.6.1 -> 3.0.0 (⚠ API breaking changes)

⚠ zip breaking changes

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron

Failed in:
  feature proc-macro2 in the package's Cargo.toml
  feature deflate-zlib in the package's Cargo.toml
  feature deflate-miniz in the package's Cargo.toml
  feature deflate-zlib-ng in the package's Cargo.toml
  feature flate2 in the package's Cargo.toml
Changelog

3.0.0 - 2025-05-14

πŸ› Bug Fixes

  • return correct offset in SeekableTake::seek (#342)
  • When only zopfli is available, decompression of deflate should not be possible (#348)
  • Specify flate2 dependency of the deflate-flate2 feature. (#345)

βš™οΈ Miscellaneous Tasks

  • fix typo
  • remove deflate-flate2 dependency on specific backend
  • [breaking] Drop deprecated deflate-miniz feature flag (#351)


This PR was generated with release-plz.

@Pr0methean
Copy link
Member Author

Pr0methean commented May 12, 2025

Canceling CI to await a version bump to 3.0.0 once #351 is merged.

@Pr0methean Pr0methean changed the title chore: release v2.6.2 chore: release v3.0.0 May 12, 2025
@Pr0methean Pr0methean force-pushed the release-plz-2025-05-12T23-05-24Z branch from 2d03514 to 3a491de Compare May 12, 2025 23:55
@joshtriplett
Copy link
Contributor

joshtriplett commented May 13, 2025

@Pr0methean Please don't have deflate-flate2 depend on the flate2/rust_backend feature. That makes it difficult for users who want to use a different flate2 backend and don't want to build the (slow) rust_backend.

Previously, deflate-flate2 seemed to be intended as a "just use flate2 but let me specify the backend" feature, whereas e.g. features like flate2-zlib-ng pulled in specific backends.

Alternatively, if you want to make deflate-flate2 be more automatic, consider having deflate-flate2 depend on flate2/zlib-rs (which is much faster), and then providing a deflate-flate2-nobackend which just depends on dep:flate2 and lets the user pick a backend. If you do that then you could probably drop all the other backend-specific features.

@Pr0methean
Copy link
Member Author

@joshtriplett Fixed in 7762944.

@joshtriplett
Copy link
Contributor

@Pr0methean I've got an alternate PR that I think a new major version is the perfect time for. Submitting that now...

@joshtriplett
Copy link
Contributor

joshtriplett commented May 13, 2025

#352

Needs a new major version because it modifies and drops features, and modifies the defaults. And since this is a new major version, it's the perfect time to switch the default backend, because people will be switching to the new version deliberately rather than having it show up in a cargo update.

@Pr0methean Pr0methean force-pushed the release-plz-2025-05-12T23-05-24Z branch 4 times, most recently from 7deb6b4 to 5b5191b Compare May 13, 2025 03:44
@Pr0methean Pr0methean added this to the 3.0.0 milestone May 13, 2025
@Pr0methean Pr0methean force-pushed the release-plz-2025-05-12T23-05-24Z branch from 5b5191b to 4546ed6 Compare May 13, 2025 03:53
@Pr0methean Pr0methean force-pushed the release-plz-2025-05-12T23-05-24Z branch 6 times, most recently from ad0ae31 to 98844d5 Compare May 14, 2025 09:48
@Pr0methean Pr0methean force-pushed the release-plz-2025-05-12T23-05-24Z branch from 98844d5 to 36713d1 Compare May 14, 2025 16:40
@Pr0methean Pr0methean closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants