Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats Effect 3 context #2343

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Cats Effect 3 context #2343

wants to merge 4 commits into from

Conversation

voropaevp
Copy link

Problem

Cats effect 3 context for Cassandra. My previous PR got merged and then lost. And Cassandra drivers got a new release, so an update is necessary.

Some unit tests are failing, complaining about missing keyspace, but same error happens in quill-cassandra itself.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@deusaquilus
Copy link
Collaborator

Wow @voropaevp this is very impressive!

@voropaevp
Copy link
Author

voropaevp commented Dec 14, 2021

Added another commit, that fixes the tests in all cassandra projects. Retested my changes and they are working fine.

@deusaquilus Let me know what you think about this change. Should it go in separate branch?

@voropaevp
Copy link
Author

Cleanly split fix for the cassandra tests and CE context

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2021

CLA assistant check
All committers have signed the CLA.

@deusaquilus
Copy link
Collaborator

deusaquilus commented Dec 22, 2021

How's it going @voropaevp? Everything looks great so far!

@voropaevp
Copy link
Author

voropaevp commented Dec 22, 2021

@deusaquilus I'm doing alright thanks for asking! How are you?

I see that my change for the tests had broken down the setup_bigdata.sh build script.
That is no longer required since migrations are handled within the docker build.

Having migrations in Dockerfile is more convenient because docker-compose run sbt sbt test will just work making development a bit more seamless. But I am happy to remove this change if you disagree.

Please approve the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants