Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer.commit method instead of record.offset.commit #1093

Closed
wants to merge 3 commits into from

Conversation

svroonland
Copy link
Collaborator

@svroonland svroonland commented Oct 29, 2023

Enforces that a Consumer is in scope when committing an offset, instead of record.offset.commit.

Also:

  • Remove deprecated merge method from OffsetBatch
  • Combine OffsetBatch.add and OffsetBatch.commit

See also #1022, #1042.

@erikvanoosten
Copy link
Collaborator

I like where this is going... :)

@svroonland
Copy link
Collaborator Author

Cool. This would be a backwards-incompatible change, so it has to be worth the benefits. We could perhaps deprecate the old commit method for a while.

@erikvanoosten
Copy link
Collaborator

Cool. This would be a backwards-incompatible change, so it has to be worth the benefits. We could perhaps deprecate the old commit method for a while.

Yes, definitely.

@svroonland svroonland closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants