Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZLayer visualization #473

Draft
wants to merge 1 commit into
base: idea241.x
Choose a base branch
from
Draft

ZLayer visualization #473

wants to merge 1 commit into from

Conversation

hmemcpy
Copy link
Collaborator

@hmemcpy hmemcpy commented May 20, 2024

WIP

This (mess of a) PR introduces the ZLayer gutter icon + supporting rendering the ZLayer graph as a mermaid diagram (currently using an online mermaid.js service, later will try to embed in IDEA directly)
image

case Left(buildErrors) => Left(graphToConstructionErrors(buildErrors))
case Right(tree) =>
// forgive me for I have side-effected :(
expr.putUserData(GraphDataKey, tree)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgive me @myazinn for I have sinned :D
(I need to recover the LayerTree somehow... any ideas are most welcome!)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature look too good for me to grumble on side-effects 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This desperately needs a State, but screw it :)
My initial approach was to duplicate the inspection logic inside the gutter, but I decided against it. Passing data in the element's cache is good enough for now.

Just need to tweak the gutter menu.
Thanks! :)

@hmemcpy hmemcpy marked this pull request as draft May 20, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants