Optimize some zio.http.endpoint.Endpoint code
#3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please reopen when it builds |
guizmaii
force-pushed
the
optimise/handlers
branch
2 times, most recently
from
a47f508 to
e1f0a79
Compare
|
@987Nabil Should be good now :) |
Replace the `NonEmptyChunk.formChunk(...).getOrElse(...)` with `chunk.nonEmptyOrElse(...)(...)`
guizmaii
force-pushed
the
optimise/handlers
branch
from
e1f0a79 to
ab6e100
Compare
987Nabil
requested changes
Dec 2, 2024
| @@ -55,7 +55,8 @@ final case class Endpoint[PathInput, Input, Err, Output, Auth <: AuthType]( | |||
| codecError: HttpCodec[HttpCodecType.ResponseType, HttpCodecError], | |||
| documentation: Doc, | |||
| authType: Auth, | |||
| ) { self => | |||
| ) { | |||
There was a problem hiding this comment.
Unrelated and unnecessary format change
| authCodec(auth1).orElseEither(authCodec(auth2))(Alternator.leftRightEqual[Unit]) | ||
| } | ||
| def authCodec(authType: AuthType): HttpCodec[HttpCodecType.RequestType, Unit] = | ||
| authType match { |
There was a problem hiding this comment.
Unrelated and unnecessary format change
987Nabil
requested changes
Dec 16, 2024
| handlers: Chunk[(Handler[Env, Nothing, Request, Response], HttpCodec.Fallback.Condition)], | ||
| ): NonEmptyChunk[(Handler[Env, Response, Request, Response], HttpCodec.Fallback.Condition)] = { | ||
| def noFound: NonEmptyChunk[(Handler[Env, Response, Request, Response], HttpCodec.Fallback.Condition)] = | ||
| NonEmptyChunk( |
There was a problem hiding this comment.
Can't we make this a constant?
987Nabil
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
NonEmptyChunk.formChunk(...).getOrElse(...)withchunk.nonEmptyOrElse(...)(...)Removes an
Optionallocation