Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Routes environment via context providing middleware #2504

Closed
wants to merge 1 commit into from

Conversation

987Nabil
Copy link
Contributor

No description provided.

@987Nabil 987Nabil force-pushed the resolve-routes-env-via-context branch from 4c01f31 to 3fc353e Compare October 31, 2023 10:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88730b0) 64.95% compared to head (3fc353e) 64.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   64.95%   64.98%   +0.02%     
==========================================
  Files         136      136              
  Lines        7197     7191       -6     
  Branches     1296     1326      +30     
==========================================
- Hits         4675     4673       -2     
+ Misses       2522     2518       -4     
Files Coverage Δ
...o-http/src/main/scala/zio/http/HandlerAspect.scala 74.46% <100.00%> (+0.81%) ⬆️
zio-http/src/main/scala/zio/http/Routes.scala 77.77% <100.00%> (+1.30%) ⬆️
...n/scala/zio/http/endpoint/EndpointMiddleware.scala 74.35% <ø> (+1.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil
Copy link
Contributor Author

It was running locally, but is having a problem with some missing tag in the pipeline. Might take a look later.

@davidlar
Copy link
Contributor

davidlar commented Dec 4, 2023

This would be very nice to have!

@987Nabil
Copy link
Contributor Author

987Nabil commented Dec 5, 2023

This approche does not work. I am working on something else.

@987Nabil 987Nabil closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants