fix: Avoid IPv6 in system DNS queries by default (#2280) #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are cases where users cannot use IPv6 due to their network infrastructure not supporting it. Therefore, we should not resolve hostnames to IPv6 addresses unless told otherwise. This commit defaults DNS queries to IPv4-only. It also allows users to resolve IPv6 addresses by setting the system property `java.net.preferIPv6Addresses`. /claim zio#2280 Reference: https://docs.oracle.com/javase/8/docs/technotes/guides/net/ipv6_guide/
This fixes build issue on MacOS (netty/netty#13632).
lackhoa
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2464 +/- ##
=======================================
Coverage 64.75% 64.75%
=======================================
Files 135 135
Lines 7135 7136 +1
Branches 1200 1224 +24
=======================================
+ Hits 4620 4621 +1
Misses 2515 2515
☔ View full report in Codecov by Sentry. |
|
I wanna change the branch name, so closing this (will open a new one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are cases where users cannot use IPv6 due to their network
infrastructure not supporting it. Therefore, we should not resolve hostnames to
IPv6 addresses unless told otherwise.
This commit defaults DNS queries to IPv4-only. It also allows users to resolve
IPv6 addresses by setting the system property
java.net.preferIPv6Addresses./claim #2280
Reference: https://docs.oracle.com/javase/8/docs/technotes/guides/net/ipv6_guide/