Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use richtext codec for content type #2455

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

TomTriple
Copy link
Contributor

Commit due to #2416

  • use RichTextCodec for ContentType header
  • accept multiple parameters in ContentType (but only keep boundary and charset around after parsing)
  • accept quoted version for parameter values

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Patch coverage: 95.16% and project coverage change: +0.52% 🎉

Comparison is base (8780eb9) 64.21% compared to head (b033266) 64.74%.

❗ Current head b033266 differs from pull request most recent head 592fed8. Consider uploading reports for the commit 592fed8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
+ Coverage   64.21%   64.74%   +0.52%     
==========================================
  Files         136      136              
  Lines        7118     7148      +30     
  Branches     1302     1298       -4     
==========================================
+ Hits         4571     4628      +57     
+ Misses       2547     2520      -27     
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/Header.scala 63.52% <94.73%> (+2.15%) ⬆️
zio-http/src/main/scala/zio/http/MediaType.scala 96.55% <100.00%> (+0.12%) ⬆️
.../src/main/scala/zio/http/codec/RichTextCodec.scala 88.58% <100.00%> (+4.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomTriple TomTriple force-pushed the better-content-type-parsing branch 3 times, most recently from 39f8106 to 592fed8 Compare September 22, 2023 14:56
@TomTriple TomTriple force-pushed the better-content-type-parsing branch from 592fed8 to 69b49fb Compare September 22, 2023 15:02
@jdegoes jdegoes merged commit 48af67d into zio:main Sep 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants