feat(wasm(host)): Add AddMod and MulMod to host functions

[malik672]

Resolves #275

• Add AddMod and MulMod to host functions
• Implement Test for both

0x30bE4D758d86cfb1Ae74Ae698f2CF4BA7dC8d693

[malik672]

@clearloop this should be done

[clearloop]

@clearloop this should be done

nice! you already got how it works! btw could you please check my template implementation in issue-275-template, especially the commit 339daeb

• we need to complete this interface for the rust primitive numbers, e.g i8, u8...i64, u64
• introduce a test in zink/examples/addmod.rs

feel free to copy my previous code to your PR!

[clearloop]

The key point of this issue is implementing addmod & mumod for number types, you got a correct implementation for U256, congratulations!

However, you missed adding these functions to the U256 type, and other primitive number types, you are in the correct direction, just need common rust impls and tests in contracts then!

[malik672]

nice! you already got how it works! btw could you please check my template implementation in issue-275-template, especially the commit 339daeb

• we need to complete this interface for the rust primitive numbers, e.g i8, u8...i64, u64
• introduce a test in zink/examples/addmod.rs

feel free to copy my previous code to your PR!

a macro would be good for this tbh

[clearloop]

a macro would be good for this tbh

yes! feel free! you may interest with my template implementation for #252 as well e0e0f4b, there is a impl_byte macro just like what we need here ^ ^

[malik672]

@clearloop didn't really get the test tbh

[clearloop]

Almost there! when you run the tests, you can do

RUST_LOG=trace cargo nextest run --example addmod --nocapture

so you will see error failed to load contract addmod_i32

1. You should load addmod which is the name of the example, we're compiling each example as a contract, and with the logging you actually can debug what happened in the compiler
2. add addmod & mulmod branches to HostFunc::TryFrom then we can emit ADDMOD & MULMOD instead of NOOP, feel free to optimize the TryFrom since our functions are increasing!

see also my workaround based on your commits: c6a1e38

[malik672]

Almost there! when you run the tests, you can do

RUST_LOG=trace cargo nextest run --example addmod --nocapture

so you will see error failed to load contract addmod_i32

1. You should load addmod which is the name of the example, we're compiling each example as a contract, and with the logging you actually can debug what happened in the compiler
2. add addmod & mulmod branches to HostFunc::TryFrom then we can emit ADDMOD & MULMOD instead of NOOP, feel free to optimize the TryFrom since our functions are increasing!

see also my workaround based on your commits: c6a1e38

yeah just looked at it, that would be messy a bit

[clearloop]

Why the test is still ignored, we need to pass the contract test to confirm that our implementation is correct

[clearloop]

Thanks for the contribution!

Please fix the format check in CI btw, everything looks nice now! will transfer the budget once the CI pass!

[clearloop]

Looks good though! Thanks!

https://polygonscan.com/tx/0xe348c4a8736d951d0d893e7f1ccba6c0e3262a8db2eacceabff56abb761e775c