Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fixed arrays from calldata #252

Open
clearloop opened this issue Oct 30, 2024 · 0 comments · Fixed by #293
Open

Load fixed arrays from calldata #252

clearloop opened this issue Oct 30, 2024 · 0 comments · Fixed by #293
Labels
budget-$150 Payable large onboarding issues

Comments

@clearloop
Copy link
Member

clearloop commented Oct 30, 2024

Describe the feature

#[zink::external]
fn foo(array: [U256, 2]) {
  // ...
}

Solution

  1. register the array types to ABI
  2. pass ABI to the compiler
  3. in the code generator, detect the length of the arrays from function signature ( which is passed from 2. )
  4. process the fixed length to bytecode for operating this type
@clearloop clearloop added the memory The issue is related to the memory model label Nov 14, 2024
@clearloop clearloop added budget-$50 Payable small onboarding issues budget-$150 Payable large onboarding issues and removed memory The issue is related to the memory model budget-$50 Payable small onboarding issues labels Nov 30, 2024
@clearloop clearloop linked a pull request Dec 2, 2024 that will close this issue
4 tasks
@clearloop clearloop reopened this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
budget-$150 Payable large onboarding issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant