Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort value transfers #1480

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Sort value transfers #1480

merged 11 commits into from
Nov 7, 2024

Conversation

AloeareV
Copy link
Contributor

@AloeareV AloeareV commented Oct 29, 2024 •
edited
Loading

This will sort any new value transfers...I don't think it will properly sort transfers created in transactions before this change, as it relies on storing new information in the wallet.

@AloeareV AloeareV marked this pull request as draft October 29, 2024 20:11
@AloeareV AloeareV marked this pull request as ready for review October 30, 2024 20:13
fluidvanadium
fluidvanadium previously requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i like where this is going with including output indexes. those are going to help sort ValueTransfers eventually?

zingolib/src/wallet/transaction_record.rs Show resolved Hide resolved
zingolib/src/wallet/data.rs Outdated Show resolved Hide resolved
@fluidvanadium fluidvanadium self-requested a review November 1, 2024 15:52
@fluidvanadium
Copy link
Contributor

assigning to juanky as he has a clearer view of issue #1461

@fluidvanadium fluidvanadium self-requested a review November 4, 2024 19:32
juanky201271
juanky201271 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If every time that the App get the VT List the order is the same... I'm happy with that.

@AloeareV AloeareV merged commit 03c1918 into zingolabs:dev Nov 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanky201271 juanky201271 juanky201271 approved these changes

@fluidvanadium fluidvanadium Awaiting requested review from fluidvanadium

Assignees

@juanky201271 juanky201271

@AloeareV AloeareV

@fluidvanadium fluidvanadium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AloeareV @fluidvanadium @juanky201271