Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonrpc #26

Merged
merged 41 commits into from
Jul 18, 2024
Merged

Add jsonrpc #26

merged 41 commits into from
Jul 18, 2024

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented May 24, 2024

Adds jsonRPC client for communication with full node (zebrad/zcashd) and implements lwd service RPCs.

Removes Zingo-Proxy's dependency on LightWalletD.

  • Add JsonRpcConnector for communication with node along with structs for input / output types.
  • Implements lightwallet service RPCs required by zingolib.
  • Adds Connection checker to establish connection with node on startup.
  • Adds new startup message.
  • Adds full block and transaction deserialization implementations required for the blockcache (currently used by get_block_range RPC).
  • Adds mempool state monitoring functionality required by the blockcache state engine (currently used by get_mempool_stream RPC).

Closes #27, #29

@idky137
Copy link
Contributor Author

idky137 commented May 24, 2024

built on top of #15, merge that pr before reviewing here.

@idky137 idky137 marked this pull request as ready for review May 24, 2024 15:15
@idky137 idky137 marked this pull request as draft May 28, 2024 16:58
zingo-proxyd/src/proxy.rs Outdated Show resolved Hide resolved
zingo-rpc/src/utils.rs Outdated Show resolved Hide resolved
@idky137
Copy link
Contributor Author

idky137 commented Jun 17, 2024

All lightwallet RPC's zingolib use are now implemented. get_block_range and get_mempool_stream should be reimplemented once the internal blockcache and state engine are implemented but are working, just slow. There are a few unwraps i want to handle and a few clippy errors but apart from a some small fixes this PR is now code complete. I know its got quite big so if needed I can split it into a few separate PRs.

@idky137 idky137 marked this pull request as ready for review June 18, 2024 17:05
@idky137 idky137 requested a review from AloeareV June 18, 2024 17:06
@idky137 idky137 mentioned this pull request Jun 20, 2024
@Oscar-Pepper Oscar-Pepper merged commit 1cbd634 into zingolabs:dev Jul 18, 2024
2 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JsonRPC Client
3 participants