Skip to content

Commit

Permalink
change ALWAYS_CACHE=True default (#891)
Browse files Browse the repository at this point in the history
* set `ALWAYS_CACHE=True`

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove legacy `git_only_repo` test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix line length

* update tests, update warning

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
PythonFZ and pre-commit-ci[bot] authored Feb 20, 2025
1 parent 969fd17 commit ad3f430
Show file tree
Hide file tree
Showing 19 changed files with 110 additions and 124 deletions.
2 changes: 1 addition & 1 deletion tests/files/dvc_config/add.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ stages:
- LICENSE
metrics:
- nodes/ReadFile/node-meta.json:
cache: false
cache: true
outs:
- nodes/ReadFile/content.json
6 changes: 3 additions & 3 deletions tests/files/dvc_config/apply.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ stages:
cmd: zntrack run zntrack.examples.nodes.ParamsToOuts --name ParamsToOuts
metrics:
- nodes/ParamsToOuts/node-meta.json:
cache: false
cache: true
outs:
- nodes/ParamsToOuts/outs.json
params:
Expand All @@ -12,7 +12,7 @@ stages:
cmd: zntrack run zntrack.examples.nodes.ParamsToOuts --name ParamsToOuts_1 --method join
metrics:
- nodes/ParamsToOuts_1/node-meta.json:
cache: false
cache: true
outs:
- nodes/ParamsToOuts_1/outs.json
params:
Expand All @@ -21,7 +21,7 @@ stages:
cmd: zntrack run zntrack.examples.nodes.ParamsToOuts --name ParamsToOuts_2 --method join
metrics:
- nodes/ParamsToOuts_2/node-meta.json:
cache: false
cache: true
outs:
- nodes/ParamsToOuts_2/outs.json
params:
Expand Down
2 changes: 1 addition & 1 deletion tests/files/dvc_config/basic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ stages:
- nodes/MyNode/my_metrics.json:
cache: false
- nodes/MyNode/node-meta.json:
cache: false
cache: true
outs:
- no-cache-plots.json:
cache: false
Expand Down
6 changes: 3 additions & 3 deletions tests/files/dvc_config/combined_dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ stages:
cmd: zntrack run test_combined_dependencies.NodeA --name NodeA
metrics:
- nodes/NodeA/node-meta.json:
cache: false
cache: true
outs:
- nodes/NodeA/results.json
NodeA_1:
cmd: zntrack run test_combined_dependencies.NodeA --name NodeA_1
metrics:
- nodes/NodeA_1/node-meta.json:
cache: false
cache: true
outs:
- nodes/NodeA_1/results.json
NodeB:
Expand All @@ -20,4 +20,4 @@ stages:
- nodes/NodeA_1/results.json
metrics:
- nodes/NodeB/node-meta.json:
cache: false
cache: true
2 changes: 1 addition & 1 deletion tests/files/dvc_config/custom_field.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ stages:
cmd: zntrack run test_custom_field.TextNode --name TextNode
metrics:
- nodes/TextNode/node-meta.json:
cache: false
cache: true
outs:
- nodes/TextNode/content.h5
2 changes: 1 addition & 1 deletion tests/files/dvc_config/custom_module.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ stages:
cmd: zntrack run zntrack.mymodule.NodeFromCustomModule --name NodeFromCustomModule
metrics:
- nodes/NodeFromCustomModule/node-meta.json:
cache: false
cache: true
10 changes: 5 additions & 5 deletions tests/files/dvc_config/dataclass_deps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@ stages:
cmd: zntrack run test_dataclass_deps.MD --name MD
metrics:
- nodes/MD/node-meta.json:
cache: false
cache: true
params:
- MD
md2_MD2:
cmd: zntrack run test_dataclass_deps.MD2 --name md2_MD2
metrics:
- nodes/md2/MD2/node-meta.json:
cache: false
cache: true
params:
- md2_MD2
md3_MD:
cmd: zntrack run test_dataclass_deps.MD --name md3_MD
metrics:
- nodes/md3/MD/node-meta.json:
cache: false
cache: true
params:
- md3_MD
multiple_deps_MD:
Expand All @@ -26,13 +26,13 @@ stages:
- nodes/multiple_deps/MLThermostat/node-meta.json
metrics:
- nodes/multiple_deps/MD/node-meta.json:
cache: false
cache: true
params:
- multiple_deps_MD
multiple_deps_MLThermostat:
cmd: zntrack run test_dataclass_deps.MLThermostat --name multiple_deps_MLThermostat
metrics:
- nodes/multiple_deps/MLThermostat/node-meta.json:
cache: false
cache: true
params:
- multiple_deps_MLThermostat
58 changes: 26 additions & 32 deletions tests/files/dvc_config/dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@ stages:
NodeA1:
cmd: zntrack run test_dependencies.NodeA1 --name NodeA1
metrics:
- nodes/NodeA1/a.json:
cache: false
- nodes/NodeA1/b.json:
cache: false
- nodes/NodeA1/metrics.json:
cache: false
- nodes/NodeA1/a.json
- nodes/NodeA1/b.json
- nodes/NodeA1/metrics.json
- nodes/NodeA1/node-meta.json:
cache: false
cache: true
outs:
- nodes/NodeA1/my_output.txt
- nodes/NodeA1/p1.csv
Expand All @@ -30,14 +27,11 @@ stages:
NodeA2:
cmd: zntrack run test_dependencies.NodeA2 --name NodeA2
metrics:
- nodes/NodeA2/a.json:
cache: false
- nodes/NodeA2/b.json:
cache: false
- nodes/NodeA2/metrics.json:
cache: false
- nodes/NodeA2/a.json
- nodes/NodeA2/b.json
- nodes/NodeA2/metrics.json
- nodes/NodeA2/node-meta.json:
cache: false
cache: true
outs:
- nodes/NodeA2/my_output.txt
- nodes/NodeA2/p1.csv
Expand All @@ -52,7 +46,7 @@ stages:
- nodes/NodeA2/results.json
metrics:
- nodes/NodeB/node-meta.json:
cache: false
cache: true
dependent_NodeC:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC
deps:
Expand All @@ -66,51 +60,51 @@ stages:
- nodes/NodeA1/results.json
metrics:
- nodes/dependent/NodeC/node-meta.json:
cache: false
cache: true
dependent_NodeC_1:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_1
deps:
- nodes/NodeA1/results.json
metrics:
- nodes/dependent/NodeC_1/node-meta.json:
cache: false
cache: true
dependent_NodeC_2:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_2
deps:
- nodes/NodeA1/metrics.json
metrics:
- nodes/dependent/NodeC_2/node-meta.json:
cache: false
cache: true
dependent_NodeC_3:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_3
deps:
- nodes/NodeA1/plots.csv
metrics:
- nodes/dependent/NodeC_3/node-meta.json:
cache: false
cache: true
dependent_NodeC_4:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_4
deps:
- nodes/NodeA1/my_output.txt
metrics:
- nodes/dependent/NodeC_4/node-meta.json:
cache: false
cache: true
dependent_NodeC_5:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_5
deps:
- nodes/NodeA1/a.json
- nodes/NodeA1/b.json
metrics:
- nodes/dependent/NodeC_5/node-meta.json:
cache: false
cache: true
dependent_NodeC_6:
cmd: zntrack run test_dependencies.NodeC --name dependent_NodeC_6
deps:
- nodes/NodeA1/p1.csv
- nodes/NodeA1/p2.csv
metrics:
- nodes/dependent/NodeC_6/node-meta.json:
cache: false
cache: true
independent_NodeC:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC
deps:
Expand All @@ -125,39 +119,39 @@ stages:
- nodes/NodeA2/results.json
metrics:
- nodes/independent/NodeC/node-meta.json:
cache: false
cache: true
independent_NodeC_1:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_1
deps:
- nodes/NodeA2/node-meta.json
- nodes/NodeA2/results.json
metrics:
- nodes/independent/NodeC_1/node-meta.json:
cache: false
cache: true
independent_NodeC_2:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_2
deps:
- nodes/NodeA2/metrics.json
- nodes/NodeA2/node-meta.json
metrics:
- nodes/independent/NodeC_2/node-meta.json:
cache: false
cache: true
independent_NodeC_3:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_3
deps:
- nodes/NodeA2/node-meta.json
- nodes/NodeA2/plots.csv
metrics:
- nodes/independent/NodeC_3/node-meta.json:
cache: false
cache: true
independent_NodeC_4:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_4
deps:
- nodes/NodeA2/my_output.txt
- nodes/NodeA2/node-meta.json
metrics:
- nodes/independent/NodeC_4/node-meta.json:
cache: false
cache: true
independent_NodeC_5:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_5
deps:
Expand All @@ -166,7 +160,7 @@ stages:
- nodes/NodeA2/node-meta.json
metrics:
- nodes/independent/NodeC_5/node-meta.json:
cache: false
cache: true
independent_NodeC_6:
cmd: zntrack run test_dependencies.NodeC --name independent_NodeC_6
deps:
Expand All @@ -175,23 +169,23 @@ stages:
- nodes/NodeA2/p2.csv
metrics:
- nodes/independent/NodeC_6/node-meta.json:
cache: false
cache: true
property_NodeC:
cmd: zntrack run test_dependencies.NodeC --name property_NodeC
deps:
- nodes/property/NodeWithProperty/node-meta.json
metrics:
- nodes/property/NodeC/node-meta.json:
cache: false
cache: true
property_NodeC_1:
cmd: zntrack run test_dependencies.NodeC --name property_NodeC_1
deps:
- nodes/property/NodeWithProperty/node-meta.json
metrics:
- nodes/property/NodeC_1/node-meta.json:
cache: false
cache: true
property_NodeWithProperty:
cmd: zntrack run test_dependencies.NodeWithProperty --name property_NodeWithProperty
metrics:
- nodes/property/NodeWithProperty/node-meta.json:
cache: false
cache: true
10 changes: 5 additions & 5 deletions tests/files/dvc_config/groups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,34 @@ stages:
cmd: zntrack run test_groups.MyNode --name Grp_B_MyNode
metrics:
- nodes/Grp/B/MyNode/node-meta.json:
cache: false
cache: true
params:
- Grp_B_MyNode
Grp_MyNode:
cmd: zntrack run test_groups.MyNode --name Grp_MyNode
metrics:
- nodes/Grp/MyNode/node-meta.json:
cache: false
cache: true
params:
- Grp_MyNode
Grp_MyNode_1:
cmd: zntrack run test_groups.MyNode --name Grp_MyNode_1
metrics:
- nodes/Grp/MyNode_1/node-meta.json:
cache: false
cache: true
params:
- Grp_MyNode_1
Grp_MyNode_2:
cmd: zntrack run test_groups.MyNode --name Grp_MyNode_2
metrics:
- nodes/Grp/MyNode_2/node-meta.json:
cache: false
cache: true
params:
- Grp_MyNode_2
MyNode:
cmd: zntrack run test_groups.MyNode --name MyNode
metrics:
- nodes/MyNode/node-meta.json:
cache: false
cache: true
params:
- MyNode
2 changes: 1 addition & 1 deletion tests/files/dvc_config/meta_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ stages:
cmd: zntrack run test_meta_params.MyNode --name some-node
metrics:
- nodes/some-node/node-meta.json:
cache: false
cache: true
15 changes: 6 additions & 9 deletions tests/files/dvc_config/metrics_deps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,22 @@ stages:
deps:
- nodes/ParamsToMetrics/metrics.json
metrics:
- nodes/DepsToMetrics/metrics.json:
cache: false
- nodes/DepsToMetrics/metrics.json
- nodes/DepsToMetrics/node-meta.json:
cache: false
cache: true
DepsToMetrics_1:
cmd: zntrack run zntrack.examples.nodes.DepsToMetrics --name DepsToMetrics_1
deps:
- nodes/ParamsToMetrics/node-meta.json
metrics:
- nodes/DepsToMetrics_1/metrics.json:
cache: false
- nodes/DepsToMetrics_1/metrics.json
- nodes/DepsToMetrics_1/node-meta.json:
cache: false
cache: true
ParamsToMetrics:
cmd: zntrack run zntrack.examples.nodes.ParamsToMetrics --name ParamsToMetrics
metrics:
- nodes/ParamsToMetrics/metrics.json:
cache: false
- nodes/ParamsToMetrics/metrics.json
- nodes/ParamsToMetrics/node-meta.json:
cache: false
cache: true
params:
- ParamsToMetrics
Loading

0 comments on commit ad3f430

Please sign in to comment.