storage: do not copy empty file (#62)

Signed-off-by: huanghaoyuan <[email protected]>
zilliztech · Sep 26, 2023 · 699203d · 699203d
1 parent 3c176a5
commit 699203d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/storage/client.go b/storage/client.go
@@ -138,6 +138,8 @@ func (o *ObjectAttr) SameAs(other ObjectAttr) bool {
 	return o.Length == other.Length && o.ETag == other.ETag
 }
 
+func (o *ObjectAttr) IsEmpty() bool { return o.Length == 0 }
+
 type Page struct {
 	Contents []ObjectAttr
 }

diff --git a/storage/copier.go b/storage/copier.go
@@ -98,6 +98,7 @@ type CopyPathInput struct {
 	OnSuccess func(attr ObjectAttr, total Total)
 }
 
+// getAttrs get all attrs under bucket/prefix
 func (c *Copier) getAttrs(ctx context.Context, bucket, prefix string) ([]ObjectAttr, Total, error) {
 	var attrs []ObjectAttr
 	var length int64
@@ -109,6 +110,9 @@ func (c *Copier) getAttrs(ctx context.Context, bucket, prefix string) ([]ObjectA
 			return nil, Total{}, fmt.Errorf("storage: copier list objects %w", err)
 		}
 		for _, attr := range page.Contents {
+			if attr.IsEmpty() {
+				continue
+			}
 			attrs = append(attrs, attr)
 			length += attr.Length
 			count++