-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Etcd podDisruptionBudget selection based on Kubernetes Version #82
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Rachit-Chaudhary11 <[email protected]>
Signed-off-by: Rachit-Chaudhary11 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rachit-Chaudhary11 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rachit-Chaudhary11 <[email protected]>
Reference PR : #74 |
@LoveEachDay @haorenfsa kindly take a look at this PR |
@Rachit-Chaudhary11 Hi, sry for the delay. The teem are busy with other stuff. Still, as I mentioned in #74, I insist on maintaining the etcd chart code within this repo like we're doing for MinIO. I shall launch another PR to do that. And I think we could merge this PR afterwards. Thank you again for your contribution.
You can solve this by walkaround make a milvus-helm chart package of your own repo. |
/assign |
What this PR does / why we need it:
Higher versions of Kubernetes fail to work with etcd's: policy/v1beta1, hence a configurable policy based on the kubernetes version is needed.
Error Message: No matches for kind "PodDisruptionBudget" in version "policy/v1beta1".
Reference PR: #74
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)